Skip to content

support darwin-arm64 #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 29, 2021
Merged

support darwin-arm64 #80

merged 5 commits into from
Apr 29, 2021

Conversation

emyarod
Copy link
Contributor

@emyarod emyarod commented Apr 27, 2021

Closes #49

running the build script seems to function as expected but I will need some help with regards to the cached releases and updating the relevant portions of the project README (is the ffmpeg version being bumped? etc). also unsure if curling the osxexperts page is sufficient for a darwin-arm64.README

@emyarod
Copy link
Contributor Author

emyarod commented Apr 27, 2021

@derhuerst is this PR on the right track and if so how should I proceed?

Copy link
Collaborator

@derhuerst derhuerst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just some minor things.

@emyarod emyarod requested a review from derhuerst April 29, 2021 03:15
@emyarod emyarod marked this pull request as ready for review April 29, 2021 15:11
@derhuerst derhuerst merged commit 78dd999 into eugeneware:master Apr 29, 2021
@emyarod emyarod deleted the darwin-arm64 branch April 30, 2021 00:03
@raymondjacobson
Copy link

hi @derhuerst! I'm wondering what's the timeline on cutting a release with this change?

@derhuerst
Copy link
Collaborator

We're waiting on someone to publish a win32 binary, see #78.

srubin added a commit to descriptinc/ffmpeg-ffprobe-static that referenced this pull request Sep 15, 2023
* Update host for Windows binaries, closes eugeneware#60

* upgrade deps & dev deps

* Travis CI: run install script manually 💚

* download win32-x64 binary from gyan.dev

see also eugeneware#76

* fix linux-{x64,ia32,arm,arm64} binary downloads 💚

* fix binary publishing 💚

* add compressed binaries to GitHub release

* install script: download gzipped binary ⚡️

closes eugeneware#69

* upgrade deps & dev deps

* use 4.3.2 binaries, 4.2.8

fixes eugeneware#76

* support FreeBSD x64

closes eugeneware#75

* minor tweaks; 4.3.0

* readme.md/package.json: mention @Thefrank's FreeBSD builds

[ci skip]

* support darwin-arm64

eugeneware#80

* build script: pull ffmpeg 4.4 binaries

* Add win32-ia32 build for 4.4

* fix FreeBSD x64 binary download 💚

* use 4.4 binaries; 4.4

* fix: upgrade eslint from 7.22.0 to 7.30.0

Snyk has created this PR to upgrade eslint from 7.22.0 to 7.30.0.

See this package in npm:
https://www.npmjs.com/package/eslint

See this project in Snyk:
https://app.snyk.io/org/derhuerst/project/cceee36c-4ce5-406d-8314-2573400ca9f6?utm_source=github&utm_medium=upgrade-pr

* Use ffmpeg version 6.0

- Updates the version of ffmpeg from 4.4 to 6.0
- Fix the download URL based on https://github.com/eugeneware/ffmpeg-static/releases

* Fix readme

* Fix readme

* adding updated package lockfile

* fix install

* Update release-binaries.yml

* Update test.yml

* build with newer node

---------

Co-authored-by: TLZ <[email protected]>
Co-authored-by: Jannis R <[email protected]>
Co-authored-by: emyarod <[email protected]>
Co-authored-by: Max Isom <[email protected]>
Co-authored-by: snyk-bot <[email protected]>
Co-authored-by: C Van Winkle <[email protected]>
Co-authored-by: vyaas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add macOS + ARM binaries from osxexperts.net
3 participants