Child class overrides lambda in parent class

[cpalasanu]

public abstract class ParentActivity extends AppCompatActivity {

    @Override
    protected void onCreate(@Nullable Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(getContentView());
        findViewById(R.id.button_parent).setOnClickListener(view -> Toast.makeText(this, "Parent onClick", Toast.LENGTH_LONG).show());
    }

    public abstract int getContentView();
}

public class MainActivity extends ParentActivity {

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);

        findViewById(R.id.button_child).setOnClickListener(view -> Toast.makeText(this, "Child onClick", Toast.LENGTH_LONG).show());
    }

    @Override
    public int getContentView() {
        return R.layout.activity_main;
    }
}

Clicking on button_parent shows a Toast with "Child onClick"

test app: https://github.com/cpalasanu/RetrolambdaTest

[Yarikx]

@cpalasanu Tested your project. Works fine for me. Parent button shows 'Parent onClick', child button shows 'Child onClick'.
Can you provide more specific configuration to reproduce or try just cleaning the cache

[calvarez-ov]

I just cloned this project, built it and ran it. Clicking on the parent button shows "Child onClick".
I made one change: to use build tools 24.0.2. I built this in a new docker container, so there was no cache.

[cpalasanu]

@Yarikx what other configuration info can I provide?
by cleaning the cache you mean do a ./gradlew clean? I did that and I still get the behavior.

[cpalasanu]

also deleted ~/.gradle/chaches and the behavior is the same

[calvarez-ov]

Using the cfr decompiler, we see that the child activity class has a method that overrides the parent activity class:

Parent:

/*
 * Decompiled with CFR 0_118.
 * 
 * Could not load the following classes:
 *  android.content.Context
 *  android.os.Bundle
 *  android.support.annotation.Nullable
 *  android.support.v7.app.AppCompatActivity
 *  android.view.View
 *  android.view.View$OnClickListener
 *  android.widget.Toast
 */
package com.orange.retrolambdatest;

import android.content.Context;
import android.os.Bundle;
import android.support.annotation.Nullable;
import android.support.v7.app.AppCompatActivity;
import android.view.View;
import android.widget.Toast;
import com.orange.retrolambdatest.ParentActivity$$Lambda$1;

public abstract class ParentActivity
extends AppCompatActivity {
    protected void onCreate(@Nullable Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        this.setContentView(this.getContentView());
        this.findViewById(2131427412).setOnClickListener(ParentActivity$$Lambda$1.lambdaFactory$(this));
    }

    public abstract int getContentView();

    /* synthetic */ void lambda$onCreate$0(View view) {
        Toast.makeText((Context)this, (CharSequence)"Parent onClick", (int)1).show();
    }
}

Child:

/*
 * Decompiled with CFR 0_118.
 * 
 * Could not load the following classes:
 *  android.content.Context
 *  android.os.Bundle
 *  android.view.View
 *  android.view.View$OnClickListener
 *  android.widget.Toast
 */
package com.orange.retrolambdatest;

import android.content.Context;
import android.os.Bundle;
import android.view.View;
import android.widget.Toast;
import com.orange.retrolambdatest.MainActivity$$Lambda$1;
import com.orange.retrolambdatest.ParentActivity;

public class MainActivity
extends ParentActivity {
    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        this.findViewById(2131427413).setOnClickListener(MainActivity$$Lambda$1.lambdaFactory$(this));
    }

    @Override
    public int getContentView() {
        return 2130968602;
    }

    @Override
    /* synthetic */ void lambda$onCreate$0(View view) {
        Toast.makeText((Context)this, (CharSequence)"Child onClick", (int)1).show();
    }
}

---

Both parent and child have the same method lambda$onCreate$0(View view)

[Yarikx]

@calvarez-ov Super interesting. I believe it's related to latest updates of retrolambda (not gradle-retrolambda). Is it reproducible with lower versions of retrolambda?

[cpalasanu]

    retrolambdaConfig 'net.orfjackal.retrolambda:retrolambda:2.2.0'

this fixes the issue so it's a problem in 2.3.0

[calvarez-ov]

I did some tests building the retrolambda project locally. It appears the bug appears in this commit: luontola/retrolambda@bf93245

I have not done any investigation to understand what part of that commit introduces the bug.

[calvarez-ov]

I opened an issue in the retrolambda project: luontola/retrolambda#109

I guess this one here may be closed.