Defensive coding to prevent out-of-range column #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There may be errors on line 1 column 1 and those resulted in a column of -62 which threw an out-of-range error.
|
I am getting this as well whenever the stack points to line 1 : #148 Thanks for the fix. Need it for alm-tools/alm#181 🌹 |
29 tasks
|
@evanw is this going to be merged any time soon? |
|
Restarting Travis, I'll merge as soon as the test goes green 👍 |
|
Hmm, Travis is failing, don't know if it's related to this PR, or just that it runs with Node.js 8.4 now (last test was run with 8.1.x) |
|
Testing out in #187 |
|
Thanks! |
|
Released as |
|
Thanks @LinusU!! Really appreciate it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There may be errors on line 1 column 1 and those resulted in a column of -62 which threw an out-of-range error.
Our example was: "v8debug is not defined" which can occur when debugging a node app from WebStorm