Cpp implementation #201

esteve · 2018-03-22T14:26:21Z

This is just a quick and rather hacky C++ port of the Javascript translator. I've added a dependency on Hunter and fmtlib for the string manipulation code and also copied over the .clang-format from cpp-ethereum.

Connects to #4

esteve · 2018-03-22T15:45:08Z

I think Travis is failing because the C++ compiler/standard library is rather old, there doesn't seem to be anything wrong with that piece of code.

lrettig · 2018-03-22T16:37:34Z

Thanks @esteve! @chfast you're probably the right person to review this.

axic · 2018-03-22T17:46:17Z

include/evm2wasm.h

+
+// maps the async ops to their call back function
+static std::map<opcodeEnum, std::string> callbackFuncs = {{opcodeEnum::SSTORE, "$callback"},
+    {opcodeEnum::SLOAD, "$callback_256"}, {opcodeEnum::CREATE, "$callback_160"},


Please do not include more of the on the same line, just one per line.

Fixed in ea8ff91

@axic You have to give up hand-tuning the code formatting.

This format is super hard to read, there must be a way to disable it.

I've found a trick to do it in clang-format: add , after the last item.

axic · 2018-03-22T17:47:43Z

Is wast-sync.h and wast-async.h handwritten, because I don't see any generator tool? Also I'd prefer them to be .cpp files to avoid recompiling them if not needed (and personally I do not like gigantic header files 😉).

axic · 2018-03-22T20:37:46Z

bin/evm2wasm.js

@@ -1,4 +1,4 @@
-#!/usr/bin/env node
+#!/usr/bin/env nodejs


Why is this needed?

This one was a leftover from when @lrettig and I tried the Javascript translator, Node is installed as nodejs in Debian.

Reverted in e519924

axic · 2018-03-23T01:48:14Z

libs/evm2wasm/evm2wasm.cpp

+
+std::string opcodeToString(opcodeEnum opcode)
+{
+    switch (opcode)


How about a map for this?

I wanted to avoid callers of this function to deal with std::pair, but I can change it to a map if you prefer.

esteve · 2018-03-23T12:53:17Z

Is wast-sync.h and wast-async.h handwritten, because I don't see any generator tool?

Just a bit of sed here and there in wast.js and wast-async.js, but I'm going to write a generator so it's all done automatically.

Also I'd prefer them to be .cpp files to avoid recompiling them if not needed

Yeah, I agree, it's rather awful 😄 I'm going to split them up and see if they look better.

chfast · 2018-03-23T16:54:02Z

I'm not sure how much work it is, but I'd rather stick to C++ library only. Adding additional dependencies is quite a big deal and we also want to compile that to WASM later on. If possible I'd use just std::string concatenation.

axic · 2018-03-26T23:13:27Z

@esteve do you want to create a new PR for the samples?

axic · 2018-03-26T23:51:05Z

Also can you please rebase and squash some commits?

lrettig · 2018-03-27T00:03:15Z

The samples are mine, I can pull these out into a separate PR, good idea

…

On 26 March 2018 at 19:51, Alex Beregszaszi ***@***.***> wrote: Also can you please rebase and squash some commits? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#201 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADKbNGfcHAcjUlB-kjHaEVjFbgmQtVtoks5tiX7qgaJpZM4S3JV7> .

lrettig · 2018-03-27T00:03:32Z

But go for it if you get to it first, @esteve!

…

On 26 March 2018 at 20:02, Lane Rettig ***@***.***> wrote: The samples are mine, I can pull these out into a separate PR, good idea On 26 March 2018 at 19:51, Alex Beregszaszi ***@***.***> wrote: > Also can you please rebase and squash some commits? > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#201 (comment)>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/ADKbNGfcHAcjUlB-kjHaEVjFbgmQtVtoks5tiX7qgaJpZM4S3JV7> > . >

esteve · 2018-03-27T14:07:45Z

@axic do you want to create a new PR for the samples?
@lrettig But go for it if you get to it first, @esteve!

Done! :-) #215

axic · 2018-04-10T01:06:49Z

@lrettig can you rebase this so it runs on circleci? Also the first and last commit are not useful anymore (the useful parts have been merged since).

esteve · 2018-04-13T13:31:04Z

@axic done, sorry for the delay. Been busy lately, but I'll address the pending feedback in the upcoming days (I hope :-))

axic · 2018-04-27T10:16:03Z

include/evm2wasm.h

@@ -351,9 +351,9 @@ struct WastCode
    std::string imports;
 };

-std::string evm2wasm(const std::string& input);
+std::string evm2wasm(const std::vector<char>& input);


Why change the public API? And what is the desired content after the change?

This is bad choice of the type. If you want to handle multiple input types consider using string_view (not in standard yet) or pass iterators.

Good points guys. Maybe it wasn't the most well-thought-out change on my part, and I will revert it.. My thinking was that bytecode is better expressed as an array of bytes as opposed to a null-terminated string.

… initialization list in C++

…execution in tests

axic reviewed Mar 22, 2018

View reviewed changes

axic reviewed Mar 23, 2018

View reviewed changes

axic mentioned this pull request Mar 26, 2018

Rewrite in C/C++ #208

Closed

esteve force-pushed the cpp-implementation branch from e519924 to ea70359 Compare March 27, 2018 14:10

esteve force-pushed the cpp-implementation branch from ea70359 to 3c49c5c Compare April 13, 2018 13:29

jwasinger force-pushed the cpp-implementation branch from 92fb153 to 4ed84b7 Compare April 22, 2018 08:18

axic force-pushed the cpp-implementation branch from 4ed84b7 to fe693a9 Compare April 23, 2018 16:45

axic reviewed Apr 27, 2018

View reviewed changes

jwasinger force-pushed the cpp-implementation branch from 750793d to 3db366d Compare April 28, 2018 07:36

jwasinger mentioned this pull request May 7, 2018

Option to generate EEI imports as a C++ file #237

Closed

axic force-pushed the cpp-implementation branch from 3db366d to 9476753 Compare May 10, 2018 11:00

axic force-pushed the cpp-implementation branch 6 times, most recently from 32721ae to d9fba6a Compare May 26, 2018 15:02

esteve and others added 24 commits August 2, 2018 03:38

Implement the basic logic in C++

8efea5c

Generate C++ header in generateInterface.js

19e0e02

Explicitly specify tuple type signature when building std::tuple from…

716edba

… initialization list in C++

Convert C++ code to deal with vector<uint8_t> and not a string

0f3edf0

Apply changes from evm2wasm#263 to cpp implementation

a5adf50

Correctly build depmap recursively in C++

e36b7d8

Apply changes from evm2wasm#200 to cpp implementation

beed04a

Apply changes from evm2wasm#265 to cpp implementation

e460905

Apply changes from evm2wasm#233 to cpp implementation

db5a644

Apply changes from evm2wasm#204 to cpp implementation

9a27cac

Run tests with C++ implementation too

3043641

Circle CI: Enforce PIC in Hera build

a13de10

Apply changes from evm2wasm#245 to cpp implementation

f11740d

Update old GNU-style field designator

fcead25

Update README with C++ specific information

1d29f4e

Use hera ef3c17f in circleci

e2a03b8

Apply changes from evm2wasm#277 to cpp implementation

c1b5060

Apply changes from evm2wasm#301 to cpp implementation

9af9372

Fix stack check typo in cpp implementation

0e5524f

Turn on chargePerOp by default in cpp implementation to match the JS …

0617c18

…execution in tests

Output push statement with signed numbers in C++ to match JS output

415a575

Fix useGas value typo in cpp implementation

d29026d

Disallow stStackTests as it surfaces a binaryen vs. wabt disagreement

4391371

Update to binaryen 1.38.9

dc7a9a3

axic force-pushed the cpp-implementation branch from 143eaf3 to a01efa5 Compare August 2, 2018 02:40

axic approved these changes Aug 2, 2018

View reviewed changes

axic added 2 commits August 2, 2018 03:45

Apply changes from evm2wasm#305 to cpp implementation

5881af0

Regenerate interfaces

a4fc405

axic force-pushed the cpp-implementation branch from a01efa5 to a4fc405 Compare August 2, 2018 02:45

axic merged commit 0bae4c6 into ewasm:master Aug 2, 2018

Cpp implementation #201

Cpp implementation #201

Uh oh!

Conversation

esteve commented Mar 22, 2018

Uh oh!

esteve commented Mar 22, 2018

Uh oh!

lrettig commented Mar 22, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

axic commented Mar 22, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

esteve commented Mar 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chfast commented Mar 23, 2018

Uh oh!

axic commented Mar 26, 2018

Uh oh!

axic commented Mar 26, 2018

Uh oh!

lrettig commented Mar 27, 2018 via email

Uh oh!

lrettig commented Mar 27, 2018 via email

Uh oh!

esteve commented Mar 27, 2018

Uh oh!

axic commented Apr 10, 2018

Uh oh!

esteve commented Apr 13, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

axic commented Mar 22, 2018 •

edited

Loading

esteve commented Mar 23, 2018 •

edited

Loading