-
-
Notifications
You must be signed in to change notification settings - Fork 641
Add Concept Exercise for type checking. #2704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Still not done!
Create all the functions using typeof
Hello. Thanks for opening a PR on Exercism 🙂 We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in. You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch. If you're interested in learning more about this auto-responder, please read this blog post. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
Sweeeet. Thanks, this is great. A response to your questions @quintuple-mallard
Yes, somewhere on the website (cannot find it now) there is a page that shows exercise information + which tracks implement it. There should be no problem with overloading the name of an exercise, but for clarity and to ensure that that page doesn't break, we should slightly change the story. Perhaps we just call this
What is the error? I can also format for you by typing
That is correct! Times have changed.
Sounds fine; we will squash at the end, so make as many commits as you want. |
The "Format code" action has started running. |
Ah. Format on the CI doesn't run because your branch is called |
rename Assembly Line to Recycling Robot
I have renamed the exercise to Recycling Robot. Here is the "Format code" script output:
|
Sorry for the closing and reopening, that came from me trying to rename the |
Some hints were outdated.
@SleeplessByte I managed to format it by switching to Windows and running the script. |
Removed now unnecessary note.
Yeah weird. The format of what command it's trying to run is off I think. I think it should have been:
But 🤷🏽 |
I think it is exercism.org/exercises/<exercise-slug> (e.g. https://exercism.org/exercises/bob) (unless there is a different one I don't know of). It throws a 500 error for Concept Exercises though. |
That's it! I'll have an in depth review for you by the weekend. Thanks for working on this, am excited! |
This PR adds the
assembly-line
exercise andtype-checking
concept to the JavaScript track.A few notes/questions:
numbers
concept, but all slightly different. Does this matter?nodejs
that I haven't been able to fix has stopped me from running theformat
script. Configlet and the other node scripts have been working.Object.hasOwn
rather thanObject.prototype.hasOwnProperty
, as it seemsObject.hasOwn
is the recommended overObject.prototype.hasOwnProperty
, that is considered somewhat outdated.