✨ Normalize "typed class constants" by removing them #299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mk-mxp there is only the last commit to review if you want to have a look. |
mk-mxp
approved these changes
Apr 28, 2025
There was a problem hiding this comment.
@homersimpsons Thanks for asking! I'm happy to have seen all of it :)
It seems to be safe to merge.
homersimpsons
force-pushed
the
feature/normaliz-class-constant-typing
branch
from
2db51b4 to
f363146
Compare
SleeplessByte
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(based on #298)
Suggested in #155