-
-
Notifications
You must be signed in to change notification settings - Fork 142
Add State of Tic-Tac-Toe Exercise #651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add State of Tic-Tac-Toe Exercise #651
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current solution using strings as the result is according to specification.
But I think, this is the perfect exercise to use an enum
as a return type. That would mean, a) changing the implementation and b) pause the merging, until we have PHP8.1 as minimum version.
I would be very happy, if you agree to wait for that. When we merge this now, we cannot change the interface later to use enum
as that invalidates all submitted solutions.
What do you think?
I'm perfectly fine with Edit: Just for information, I have added this thread to the Forum |
It's expected to fail in PHP 8.0 as I have already added the |
That's looks great! Looking forward to having a minimum of PHP 8.1... |
11122ae
to
418fa17
Compare
@tomasnorre Today the PHP track got upgraded to the required PHP version. You may rebase this branch and update the PR. |
3e54669
to
f487a58
Compare
I must have done something wrong in the rebasing. As all the changes are included. I did
Update: Looks better now. I did the sync of my fork incorrect. |
f487a58
to
0f5c86d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks a lot.
Todo: