Skip to content

Conversation

douglowder
Copy link
Contributor

@douglowder douglowder commented Sep 12, 2025

Why

To allow CLI users to get artifacts of builds or workflow jobs directly using the CLI, and make the URLs available in JSON output also (for easier use by automation scripts).

How

  • Add artifact info to WorkflowJobFragment
  • Add this info to the results of workflow:view
  • For workflow jobs that are of type=BUILD, use the existing build query to get the build artifact URLs for the build and show those as well
  • Make some improvements to the formatting of workflow job outputs

Test Plan

  • Tested against different EAS projects
  • CI should pass

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

github-actions bot commented Sep 12, 2025

Size Change: +1.41 kB (0%)

Total Size: 54.1 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 54.1 MB +1.41 kB (0%)

compressed-size-action

@douglowder douglowder marked this pull request as ready for review September 12, 2025 17:07
Copy link

Subscribed to pull request

File Patterns Mentions
packages/eas-cli/src/build/** @sjchmiela
packages/eas-cli/src/commands/workflow/** @sjchmiela

Generated by CodeMention

@douglowder douglowder force-pushed the doug/workflow-artifacts branch from 8f6e444 to b466214 Compare September 12, 2025 17:12
Copy link

codecov bot commented Sep 12, 2025

Codecov Report

❌ Patch coverage is 12.85714% with 61 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.80%. Comparing base (29950a7) to head (3d42335).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/eas-cli/src/commands/workflow/view.ts 10.00% 40 Missing and 5 partials ⚠️
packages/eas-cli/src/build/utils/formatBuild.ts 11.12% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3175      +/-   ##
==========================================
- Coverage   51.87%   51.80%   -0.07%     
==========================================
  Files         616      616              
  Lines       24835    24883      +48     
  Branches     5213     5226      +13     
==========================================
+ Hits        12880    12887       +7     
- Misses      10882    10918      +36     
- Partials     1073     1078       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@sjchmiela sjchmiela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!!

Copy link

✅ Thank you for adding the changelog entry!

@douglowder douglowder merged commit a74c434 into main Sep 15, 2025
8 checks passed
Copy link
Contributor Author

Merge activity

@douglowder douglowder deleted the doug/workflow-artifacts branch September 15, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants