refactor: improve readability #6173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix typo in condition check
bjohansebas
approved these changes
Nov 12, 2024
wesleytodd
requested changes
Nov 12, 2024
assignment was being done inside condition check leading to confusion in reading code.
|
assignment inside condition check leading to confusion in reading code. Change proposed. |
sazk07
changed the title
sazk07
changed the title
wesleytodd
approved these changes
Nov 14, 2024
UlisesGascon
approved these changes
Nov 27, 2024
UlisesGascon
changed the title
|
@UlisesGascon PR made in v4 branch. pls check from your end. |
yash-882
pushed a commit
to yash-882/express
that referenced
this pull request
Jan 27, 2025
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix typo in condition check