removed unused assets. #1493
Merged
removed unused assets. #1493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
and sorry for the inconvenience with the old pull request the vs code was asking me to fork the repo I already had forked so I deleted the fork and then forked again and that fixed it. |
|
Thanks @MehfoozurRehman ... I checked out the fork and ran it locally to make sure there were no issues, and it LGTM. I just want to make sure that there's no reason to keep these file around that I'm not thinking of, so I've asked for another review from @jonchurch just to be sure. |
crandmck
approved these changes
Apr 22, 2024
sheplu
approved these changes
Apr 22, 2024
UlisesGascon
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
according to the feedback on #1489 removed the unused assets