Remove HeterogeneousSingleTaskGP #3026
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65543676 |
Summary: Removes a couple of unused utilities form ax/models/torch/utils.py, and updates the tests to remove usage of `HeteroskedasticSingleTaskGP`. Differential Revision: D65545235
|
This pull request was exported from Phabricator. Differential Revision: D65543676 |
saitcakmak
force-pushed
the
export-D65543676
branch
from
21c0ba0 to
a94b26a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3026 +/- ##
==========================================
+ Coverage 95.60% 95.66% +0.05%
==========================================
Files 483 483
Lines 49012 48965 -47
==========================================
- Hits 46859 46841 -18
+ Misses 2153 2124 -29 ☔ View full report in Codecov by Sentry. |
|
This pull request was exported from Phabricator. Differential Revision: D65543676 |
facebook-github-bot
pushed a commit
to pytorch/botorch
that referenced
this pull request
Nov 7, 2024
Summary: X-link: facebook/Ax#3026 Pull Request resolved: #2616 This model has been buggy for quite a long time and we still haven't fixed it. Removing it should be preferable to keeping around a known buggy model. Example bug reports: - #861 - #933 - #2551 Reviewed By: esantorella Differential Revision: D65543676 fbshipit-source-id: e1a9a1e602786c750c7366eae671b92dcbf0f24b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: pytorch/botorch#2616
This model has been buggy for quite a long time and we still haven't fixed it. Removing it should be preferable to keeping around a known buggy model. Example bug reports:
Differential Revision: D65543676