Skip to content

Typescript 4.3.5 #11022

Closed
Closed
@icecream17

Description

@icecream17

Describe the bug

Typescript just released a new version: 4.3.2 4.3.5

Did you try recovering your dependencies?

N/A

Which terms did you search for in User Guide?

None (was just released June 30th)

Environment

(gitpod since I only have access to an online terminal)

Environment Info:

  current version of create-react-app: 4.0.3
  running from /home/gitpod/.nvm/versions/node/v14.17.0/lib/node_modules/create-react-app

  System:
    OS: Linux 5.4 Ubuntu 20.04.2 LTS (Focal Fossa)
    CPU: (16) x64 Intel(R) Xeon(R) CPU
  Binaries:
    Node: 14.17.0 - ~/.nvm/versions/node/v14.17.0/bin/node
    Yarn: 1.22.10 - ~/.nvm/versions/node/v14.17.0/bin/yarn
    npm: 7.14.0 - ~/.nvm/versions/node/v14.17.0/bin/npm
  Browsers:
    Chrome: Not Found
    Firefox: Not Found
  npmPackages:
    react: ^17.0.2 => 17.0.2 
    react-dom: ^17.0.2 => 17.0.2 
    react-scripts: 4.0.3 => 4.0.3 
  npmGlobalPackages:
    create-react-app: 4.0.3

Steps to reproduce

(Write your steps here:)

  1. Create a new typescript app
  2. Use the override keyword (see typescript's release notes or the repro below)
  3. Doesn't compile

Expected behavior

Now that I know the new version was just released, this is normal

Actual behavior

Discovered with:
https://github.com/icecream17/solver/runs/2686100874?check_suite_focus=true

Reproducible demo

I don't feel like making a demo so here's more detailed instructions

npx create-react-app example
cd example
npm install --save-prod typescript@4.3.2
// Then change App.tsx
class A {
  b(){}
}

class B extends A {
  override b () {}
}
npm test

Activity

added this to the 4.1 milestone on May 31, 2021
self-assigned this
on May 31, 2021
mrmckeb

mrmckeb commented on May 31, 2021

@mrmckeb
Contributor

This requires us to upgrade to a newer version of Babel.
https://github.com/babel/babel/releases/tag/v7.14.0

We often do this before a release, and I've flagged this for the next minor release - so hopefully we can get this in.

mrmckeb

mrmckeb commented on May 31, 2021

@mrmckeb
Contributor

This may actually already be partly solved by #10797, as you'll be able to upgrade dependencies now.

mrmckeb

mrmckeb commented on Jun 8, 2021

@mrmckeb
Contributor

Just a note on this @icecream17, we're hoping to ship support for this in the next minor release - providing everything else in the chain has been updated.

It looks like typescript-eslint is, which is great. So I'm hopeful :)

Gilwe

Gilwe commented on Jun 24, 2021

@Gilwe

@mrmckeb Question, when is the next minor version planned to be released?

changed the title [-]Typescript 4.3.2[/-] [+]Typescript 4.3.5[/+] on Jul 2, 2021
iansu

iansu commented on Aug 11, 2021

@iansu
Contributor

We've released the first alpha of Create React App v5 which should support TypeScript 4.3. If you have any problems please open a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Relationships

None yet

    Development

    No branches or pull requests

      Participants

      @iansu@mrmckeb@Gilwe@icecream17

      Issue actions

        Typescript 4.3.5 · Issue #11022 · facebook/create-react-app