Skip to content

Document or build with babel-polyfill #125

Closed
@modernserf

Description

@modernserf

This doesn't seem to include babel-polyfill. This would be fine for modern browsers except that Babel's generators depend on regeneratorRuntime, which is included in the polyfill. This needs to either be documented (i.e. "use babel-polyfill if you're supporting old browsers or using ES6 generators") or automatically included in the webpack build.

Activity

mxstbr

mxstbr commented on Jul 23, 2016

@mxstbr
Contributor

It's interesting because while I agree that generators should be supported, not many people will use them and the polyfill is quite a bit of code. I think documenting it might be the way to go here?

vjeux

vjeux commented on Jul 23, 2016

@vjeux
Contributor

Is there a way to add regeneratorRuntime only if you use generators?

gaearon

gaearon commented on Jul 23, 2016

@gaearon
Contributor

I thought this is how it worked but I'm probably wrong. Also worth looking at transform-runtime.

insin

insin commented on Jul 23, 2016

@insin
Contributor

Discussion about this in #51

Ad-hoc reckons on the subject of auto-polyfilling, but based on having user config: https://gist.github.com/insin/711862bb578735c54c294d24bfb024ef

gaearon

gaearon commented on Jul 27, 2016

@gaearon
Contributor

Generators should work out of the box with 0.2.0 alpha. #190

added a commit that references this issue on Feb 5, 2018

Merge pull request facebook#125 from pedsmoreira/patch-1

dea4a2b
locked and limited conversation to collaborators on Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @vjeux@insin@gaearon@modernserf@mxstbr

      Issue actions

        Document or build with babel-polyfill · Issue #125 · facebook/create-react-app