Skip to content

don't call it "My First React App" in the title #16

Closed
@lacker

Description

@lacker

Because we don't want it to only be used by people making their first react app, do we?

How about taking the name from the directory it gets created in.

Activity

gaearon

gaearon commented on Jul 18, 2016

@gaearon
Contributor

Agreed!

added this to the 0.1.0 milestone on Jul 18, 2016
vjeux

vjeux commented on Jul 18, 2016

@vjeux
Contributor

b214b17

The index.html file is currently static so it's a bit annoying to make it use the folder name. Feel free to send a diff to update it if you feel like it.

mxstbr

mxstbr commented on Jul 18, 2016

@mxstbr
Contributor

You can inject that with the HTMLWebpackPlugin from the webpack config I'm pretty sure, be wary though because that'll override whatever the users puts in there themselves.

EDIT: Sorry for the reopen, that was a misclick

reopened this on Jul 18, 2016
added 2 commits that reference this issue on Nov 13, 2016

Merge pull request facebook#17 from stereobooster/16-fix-eject

locked and limited conversation to collaborators on Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @lacker@vjeux@gaearon@mxstbr

        Issue actions

          don't call it "My First React App" in the title · Issue #16 · facebook/create-react-app