Skip to content

CSS @keyframes Best Practice #219

Closed
Closed
@hnordt

Description

@hnordt

In src/App.css we have the @keyframes spin rule:

@keyframes spin {
  from { transform: rotate(0deg); }
  to { transform: rotate(360deg); }
}

Wouldn't best to rename spin to App-logo-spin? That way we teach newcomers to avoid "CSS globals" for everything.

I mean, @keyframes spin is a good candidate to be added in many component's CSS file.

Activity

vjeux

vjeux commented on Jul 26, 2016

@vjeux
Contributor

👍 want to send a pull request?

hnordt

hnordt commented on Jul 26, 2016

@hnordt
ContributorAuthor

@vjeux sure, doing it now.

locked and limited conversation to collaborators on Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @vjeux@hnordt

        Issue actions

          CSS @keyframes Best Practice · Issue #219 · facebook/create-react-app