Skip to content

Dismiss full page reload after fixing compile errors #2217

Closed
@RohovDmytro

Description

@RohovDmytro

After making some tweaks and introducing a type in a component name

<ComponentThatDoNotExistDefinataly />

So we have compilation error. And fixing that typo leads to full page reload.

But wouldn't that be nice, if we could reject that hot-update-patch and swap it only if compilation succeeded? Or use another approach but the aim is to prevent page from reloading after fixing that typo.

Activity

changed the title [-]Dismiss full page reload after compile errors[/-] [+]Dismiss full page reload after fixing compile errors[/+] on May 18, 2017
gaearon

gaearon commented on May 18, 2017

@gaearon
Contributor

Want to make a proof of concept?

As I wrote in gaearon/react-hot-boilerplate#97 (comment), for me personally one of the goals of this project is to make a stable hot reloading experience part of React by default.

Syntax and runtime overlays are a necessary first step, and I’m excited to move beyond them and make the experience better now that more pieces are in place.

RohovDmytro

RohovDmytro commented on May 21, 2017

@RohovDmytro
Author

create-react-app made me to forget about all the inner part of webpack and other stuff 😕 Not sure I will have enough time to digg into. But I will surely help with testing stuff, because I am very excited about HMR too and it make my workflow so much better.

Timer

Timer commented on Sep 29, 2017

@Timer
Contributor

I believe a concept for this is up in #2304, I'll close this for now. 😄

locked and limited conversation to collaborators on Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @Timer@gaearon@RohovDmytro

        Issue actions

          Dismiss full page reload after fixing compile errors · Issue #2217 · facebook/create-react-app