Skip to content

Ejecting adds all packages to dependencies #3062

Closed
@tbillington

Description

@tbillington

Not a bug report, just curious why all packages are put under dependencies in package.json and none under devDependencies when ejecting with react-scripts 1.0.13. Surely things like webpack, chalk, and eslint are not runtime dependencies? I can't see it explained anywhere and I know that previously most of the packages would go under devDependencies as I am using an ejected version of an old create-react-app.

Activity

miraage

miraage commented on Sep 4, 2017

@miraage

It was removed in 1.0.8 (#2657).
It looks easy to fix on the paper.
Welcome, dependencies.
I think they should be added as devDependencies except promise, whatwg-fetch, object-assign which are used by polyfills.js as an additional entry.

gaearon

gaearon commented on Sep 4, 2017

@gaearon
Contributor

Please see #2696.

There is no real difference in our case.
Feel free to move them if you have opinions about them.

tbillington

tbillington commented on Sep 5, 2017

@tbillington
Author

Ok, I can see why, thanks for the info :)

locked and limited conversation to collaborators on Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @gaearon@miraage@tbillington

        Issue actions

          Ejecting adds all packages to dependencies · Issue #3062 · facebook/create-react-app