Skip to content

Add .gitattributes file #3080

Closed
Closed
@Timer

Description

@Timer

Windows contributors have to deal with failing test cases due to line endings when comparing to snapshot tests.

See #3065 for reference.

We should create a .gitattributes file which forces these files (all *.js files?) to be checked out with LF line feeds.

Activity

added this to the 1.x milestone on Sep 6, 2017
duvet86

duvet86 commented on Sep 7, 2017

@duvet86
Contributor

I can help with this, given that it affects me.
Cheers.

Timer

Timer commented on Sep 7, 2017

@Timer
ContributorAuthor

Great, thanks!

ijajmulani

ijajmulani commented on Sep 13, 2017

@ijajmulani
Contributor

Hi, looking to get involved in open source projects. If you want I can help you in this.

ijajmulani

ijajmulani commented on Sep 13, 2017

@ijajmulani
Contributor

Here is my PR for same.

duvet86

duvet86 commented on Sep 23, 2017

@duvet86
Contributor

Unfortunately I can't find a way to normalise files using .gitattributes.
The only solution I've found is setting:
git config --global core.autocrlf false

As per stated here:
https://stackoverflow.com/questions/2517190/how-do-i-force-git-to-use-lf-instead-of-crlf-under-windows/13154031#13154031

Cheers Luca

locked and limited conversation to collaborators on Jan 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @Timer@gaearon@ijajmulani@duvet86

        Issue actions

          Add .gitattributes file · Issue #3080 · facebook/create-react-app