Skip to content

Reconsider whether it's safe to rely on recent Uglify versions #4329

Closed
@gaearon

Description

@gaearon

I don't have all the context but just flagging to look at this before cutting 2.x.

https://mobile.twitter.com/AdamRackis/status/987346564527116288
facebook/react#12555 (comment)
facebook/react#12434

Activity

added this to the 2.0.0 milestone on Apr 20, 2018
Timer

Timer commented on Apr 21, 2018

@Timer
Contributor

Unfortunately, babel-minify is really slow: neutrinojs/neutrino#809 (comment).

gaearon

gaearon commented on Apr 21, 2018

@gaearon
ContributorAuthor

I’d be cautious with that too because we couldn’t get it to work reliably enough at FB about a year ago.

eliperelman

eliperelman commented on Apr 21, 2018

@eliperelman
Contributor

Other than build times, babel minify hasn't been too bad. I have been bit before by variable name mangling though, which was painful to debug. We are in a tough period right now with both Uglify and Babel minify not receiving the maintenance love they probably need.

Timer

Timer commented on Sep 18, 2018

@Timer
Contributor

We've switched to Terser.

locked and limited conversation to collaborators on Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @eliperelman@Timer@gaearon

        Issue actions

          Reconsider whether it's safe to rely on recent Uglify versions · Issue #4329 · facebook/create-react-app