Skip to content

Add documentation surrounding Sass support #4334

Closed
@Timer

Description

@Timer
No description provided.

Activity

added this to the 2.0.0 milestone on Apr 21, 2018
bugzpodder

bugzpodder commented on Apr 21, 2018

@bugzpodder

Just tried it out, works great. I don't know enough to properly document the feature, but in js I just do
import 'path/to/my.scss'
and inside a scss file I just do
@import 'path/to/my.scss'
and for node_module imports:
@import '~package/other.css'

Timer

Timer commented on Apr 21, 2018

@Timer
ContributorAuthor

Glad to hear it works for you -- that's what we were going for! 😃 Something that should "just work".

adamwright104

adamwright104 commented on Apr 23, 2018

@adamwright104

This is working for me. followed the install and changed the app.css and index.css to be scss and no styles show

bradfordlemley

bradfordlemley commented on Jul 13, 2018

@bradfordlemley
Contributor

Specifically, adding-a-css-preprocessor-sass-less-etc section in User Guide should be updated.

Note: node-sass needs to be included separately in app's devDependencies (intentional, as requested by CRA.)

modified the milestones: 2.0.x, 2.x on Sep 26, 2018
mareksuscak

mareksuscak commented on Sep 27, 2018

@mareksuscak
Contributor

This may have been resolved in d7bffca#diff-4e6ec56f74ee42069aac401a4fe448ad

EDIT: although there's one thing that's not documented properly - *.module.scss - it relates to both SCSS and CSS modules section of the doc (reference)

Timer

Timer commented on Sep 27, 2018

@Timer
ContributorAuthor

Feel free to send PR update, @mareksuscak!

mareksuscak

mareksuscak commented on Sep 27, 2018

@mareksuscak
Contributor

@Timer done and linked to this issue. Here's a preview.

modified the milestones: 2.x, 2.0.0 on Sep 27, 2018
locked and limited conversation to collaborators on Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @mareksuscak@Timer@bugzpodder@bradfordlemley@adamwright104

        Issue actions

          Add documentation surrounding Sass support · Issue #4334 · facebook/create-react-app