Skip to content

Reviving Add BuildProgressPlugin #6310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maniax89 opened this issue Jan 30, 2019 · 10 comments
Closed

Reviving Add BuildProgressPlugin #6310

maniax89 opened this issue Jan 30, 2019 · 10 comments

Comments

@maniax89
Copy link
Contributor

Is this a bug report?

No

I was just wondering if there was any interest in reviving the Add BuildProgressPlugin PR that got closed back in January, 2019

I believe @Timer had it working but wasn't happy with the progress accuracy -> is this still true? not sure if anything has changed but to me it seems like something would be better than nothing

anyone else interested in this? I could try and revive the PR again at some point in the next few weeks

@eladmotola
Copy link

eladmotola commented Jan 31, 2019

I think we should abandon this pr and create a new one that use this plugin instead: https://github.com/clessg/progress-bar-webpack-plugin
What do you think?

@mrmckeb
Copy link
Contributor

mrmckeb commented Feb 1, 2019

I'll let @Timer chime in on this one, as I wasn't across it in detail. If there's a newer, more accurate version, that could also be good to discuss.

By the way, "back in January, 2019" is scary to say so soon ;)

@maniax89
Copy link
Contributor Author

maniax89 commented Feb 1, 2019

You caught me :-) January 2018

@eladmotola
Copy link

@Timer what do you think? Do you want @maniax89 or me(I hope its ok Andrew) to start working on it?

@maniax89
Copy link
Contributor Author

I'm fine with you working on it @eladmotola

@stale
Copy link

stale bot commented Mar 18, 2019

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Mar 18, 2019
@maniax89
Copy link
Contributor Author

I never got a chance to work on it but would like this to stay open

@stale stale bot removed the stale label Mar 18, 2019
@iansu
Copy link
Contributor

iansu commented Mar 18, 2019

I'm going to label this as "Up for grabs" unless you think you'll have time to work on it in the near future.

@ryandrew14
Copy link

I'd like to dig into this if possible. Would acceptance criteria for this look like getting the webpack ProgressPlugin to work?

@Timer Timer removed their assignment Mar 20, 2019
@iansu
Copy link
Contributor

iansu commented Mar 20, 2019

I just learned that enabling any of these progress plugins introduces a significant performance penalty in webpack. They all require webpack to emit progress information during the build and that slows things down quite a bit. I don't think it's worth it just to display a progress bar so I'm going to close this issue.

@iansu iansu closed this as completed Mar 20, 2019
@lock lock bot locked and limited conversation to collaborators Mar 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants