Closed
Description
No description provided.
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
Milestone
Relationships
Development
No branches or pull requests
Participants
{{ message }}
No one assigned
No labels
No type
No projects
No milestone
None yet
Activity
kumar303 commentedon Feb 25, 2019
Why not? It seems like it should be possible: https://github.com/gaearon/react-hot-loader#typescript
I was able to get it working by adding react-app-rewire-hot-loader but that starts to complicate things.
kanekv commentedon Feb 28, 2019
@kumar303 does it work at all? What are complications?
kumar303 commentedon Feb 28, 2019
Yes, after following the instructions in
react-app-require-hot-loader, hot reloads seem to be working just fine. This is all I had to change in a standard create-react-app project: https://github.com/mozilla/addons-code-manager/pull/276/filesWell, it involves replacing all
react-scriptscommands withreact-app-rewired. This makes me think that upgrading to new versions ofreact-scriptswould be difficult. Also, it would introduce a non-officially supported babel/webpack configuration which might get out of sync withreact-scriptsand might create confusing bugs. It's not as bad as ejecting, though.kanekv commentedon Feb 28, 2019
It seems it works with that setup, closing this issue.
kumar303 commentedon Mar 5, 2019
Could you please re-open the issue so that it gets fixed properly in create-react-app?
stale commentedon Apr 4, 2019
This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.
kumar303 commentedon Apr 5, 2019
Could someone from the team please consider this feature? I think it's really important.
As an example: sometimes I need to perform a few clicks to set up my UI in a state for development. Without proper hot reloading, the whole page gets reloaded as I edit files and I lose my state.
iansu commentedon Apr 5, 2019
We would be happy to consider this feature but without someone from the community doing the work and submitting a PR it's probably not going to happen. We have very limited resources and can barely keep up with all the issues and PRs that come in every day.
kumar303 commentedon Apr 5, 2019
OK, I can look into making a patch for it. I just wanted to make sure there wasn't already some reason that hot reloading is disabled.
iansu commentedon Apr 5, 2019
I think the reason is just that it's tricky to get it working properly.
23 remaining items