Skip to content

Dark mode doesn't darken "Get started in seconds" section #7930

Closed
@ahtee

Description

@ahtee

Describe the bug

When enabling dark theme via the navigation bar, the site darkens completely, except the Get started in seconds section on the Home page (https://create-react-app.dev/)

Did you try recovering your dependencies?

No

Which terms did you search for in User Guide?

No terms were searched

Environment

Production create-react-app.dev site and on the home page.

Steps to reproduce

(Write your steps here:)

  1. go to create-react-app.dev
  2. In the navigation bar, change the sun toggler to night
  3. The dark theme will appear
  4. Scroll down on the Home page to see the Get started in seconds section
  5. Observe that this section ignores the dark theme

Expected behavior

(Write what you thought would happen.)

Entire site is coverted into the dark theme with shades of black (or close to black)

Actual behavior

(Write what happened. Please add screenshots!)

Screen Shot 2019-11-05 at 9 40 35 AM

Reproducible demo

(Paste the link to an example project and exact instructions to reproduce the issue.)

I am using Brave browser (new build that is based off Chromium) version 0.7.022

Activity

ahtee

ahtee commented on Nov 5, 2019

@ahtee
Author

Probably has to do with the lightBackground_19Qt class applied to the section?

added a commit that references this issue on Nov 6, 2019
ffe3fda
added a commit that references this issue on Nov 13, 2019
30b491b
locked and limited conversation to collaborators on Nov 18, 2019
added a commit that references this issue on Jan 3, 2020
d4d5df6
added a commit that references this issue on Jan 5, 2020
71e6f92
added a commit that references this issue on Jan 28, 2020
c0aa53b
added a commit that references this issue on Feb 19, 2020
102411c

6 remaining items

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @ahtee@ianschmitz

      Issue actions

        Dark mode doesn't darken "Get started in seconds" section · Issue #7930 · facebook/create-react-app