Description
Is your proposal related to a problem?
CRA uses the same favicon as reactjs.org. When developing, I often have both my app running in a tab, and React documentation in other tabs:
Describe the solution you'd like
If CRA used a red favicon, it could help distinguish these tabs. The red favicon also draws a bit more attention to itself, to help the developer remember to replace it with the app's actual favicon.
I often use CRA as a "scratchpad" just to quickly try something out, and often in that case I'm also referring to React documentation. So in that case I don't really care about swapping to a new favicon. An already red favicon would be helpful in this situation.
Red is nice as the React dev tools use a red icon to indicate a site is in dev mode. It would convey a similar meaning here too. There may be accessibility concerns. I believe the dev tools have a slightly different icon along with the color change to help with that.
Additional context
This is obviously a small feature request and its impact is on the small side. But the effort to implement it is pretty small too IMO.
Activity
ianschmitz commentedon Nov 10, 2019
Seems pretty reasonable. Let's see what the other maintainers think.
We could potentially use the React DevTools icon: https://github.com/facebook/react/blob/master/packages/react-devtools-extensions/icons/development.svg
heyimalex commentedon Nov 12, 2019
I vote for just using the new logo, maybe with the colors reversed. I think using red conveys too much danger; people will release production sites without replacing the favicon, so it should still look professional.
city41 commentedon Nov 13, 2019
That's a good idea. I'm mostly interested in a different favicon, being red isn't that important IMO.
heyimalex commentedon Nov 14, 2019
Here's my work so far. I think it's visually distinct enough, but the light border looks kinda muddy on light browsers.
iansu commentedon Nov 14, 2019
We should not be using that logo in the templates. I think just the react logo but with a different colour will have to do.
heyimalex commentedon Nov 14, 2019
Here's a different color of the original logo with a box around it. Not very visually distinct on chrome.
Here's an inverted one. Not my favorite, but maybe with a different color combination it'd be alright.
Red actually looks pretty good, but it doesn't match the branding. Not sure that matters much.
iansu commentedon Nov 14, 2019
I think the inverted one looks pretty good. We could maybe tweak the colour a bit but I like it and it definitely stands out.
city41 commentedon Dec 14, 2019
Any more thoughts on this? I'd be happy to send in a PR, but I haven't as I feel it makes more sense for the core team to choose the favicon.
heyimalex commentedon Dec 14, 2019
The templates use react branding, so I’ll submit a pr with the inverted react colors tomorrow. I think it’ll look good, it’s just the bright green that was kinda garish to me.
Replace favicon in templates
Replace favicon in templates (#8194)
Replace favicon in templates (facebook#8194)
Feat/cra update (#204)
Squashed commit of the following:
Feat/cra update (#225)
Replace favicon in templates (facebook#8194)
Feature/customized webpack plugin integration (#2)
Replace favicon in templates (facebook#8194)
Replace favicon in templates (facebook#8194)