You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As far as I can see, react-scripts has a dependency on eslint-plugin-react-hooks@^1.6.1 so that means the update from the issue you mentioned only works for apps that don't use react-scripts. I guess that's what you want to be addressed, correct?
Is there any blocker in making the update? I can't really find an exhaustive list of the changes in eslint-plugin-react-hooks to check that out.
Allow where? It is a dependency of react-scripts. No, it can't just be bumped. What needs to happen here is a bump to this dependency and a major bump of react-scripts.
Activity
ClementParis016 commentedon Mar 2, 2020
As far as I can see,
react-scripts
has a dependency oneslint-plugin-react-hooks@^1.6.1
so that means the update from the issue you mentioned only works for apps that don't usereact-scripts
. I guess that's what you want to be addressed, correct?Is there any blocker in making the update? I can't really find an exhaustive list of the changes in
eslint-plugin-react-hooks
to check that out.creatyvtype commentedon Apr 13, 2020
Regarding the version changes of
eslint-plugin-react-hooks
For version 1* to 2.0.0:
https://github.com/facebook/react/pull/16528/files
For version 2* to 3.0.0
reactjs/react.dev#2878 @gaearon mentions the changes
creatyvtype commentedon Apr 13, 2020
Would like to silence warning I'm receiving when trying to use latest version of
eslint-plugin-react-hooks
which is 3.0.0.It's mentioned in #7790 that the update of the plugin will be a breaking change for
react-scripts
. Will it be ok in the meantime to update to allow:gaearon commentedon Apr 13, 2020
Allow where? It is a dependency of
react-scripts
. No, it can't just be bumped. What needs to happen here is a bump to this dependency and a major bump ofreact-scripts
.ianschmitz commentedon May 4, 2020
Fixed in #8939.