Closed
Description
index.html
favicon.ico
src/index.js
They are all required, and we should crash early with a descriptive message if they are not found.
(Probably we could make favicon
optional but then it would be hard to guess where to put it. I see no harm in forcing it to be there since any real website needs it anyway.)
Activity
apoorvnandan commentedon Jul 22, 2016
Hey, I would like to work on this but I need some guidance. Will using npm file-exists before opening the browser do the job?
gaearon commentedon Jul 22, 2016
I would suggest to try implementing something that works and feels good. When we get the right UX we can choose to make changes to the actual implementation.
christophior commentedon Jul 22, 2016
Might take a look at this as well, I see that we already have paths that we're getting in the webpack configs so I was thinking of pulling those out since a lot of it seems like redundant data so that I could also use that in checking whether the required files exist.
vincaslt commentedon Jul 22, 2016
I guess something like that could work, tell me if it should be improved. Maybe move required file definitions to somewhat more manageable place?
delorge commentedon Aug 3, 2016
Is it easier to check that file exists via access check? Should work with any npm version. Moreover, no extra dependencies needed.
UPD: we can basically crash on errors and warn on missing favicon
gaearon commentedon Sep 18, 2016
This should be fixed in 0.4.2.
Merge pull request facebook#96 from CADBOT/update-readme