Don't assume window is defined when polyfilling Promise #1254
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know server-rendering isn't supported, but I was tinkering with loading the production bundle in Nashorn, Java 8's JavaScript engine, and found that the
Promise
polyfill assumes thatwindow
exists. This PR changes the polyfill to attempt to usewindow
first, andglobal
secondly.For the interested reader,
global
isn't defined in Nashorn either, but it can be easily defined in order to bring it in-line with Node.Testing steps: