Skip to content

Add an environment variable for disabling compression on the proxy server #13205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ThomasKluiters
Copy link

@ThomasKluiters ThomasKluiters commented Jun 1, 2023

This commit adds an environment variable 'WDS_COMPRESSION' which can be set to 'false' to opt -out of compression. This is desirable when using Server Sent Events as the proxy fails to pass Server Sent Events when compression is enabled

Though, we could optionally make the proxy more configurable by either accepting a string or a config object, allowing for more fine-grained configuration.

Fixes #1633

…rver

This commit adds an environment variable 'WDS_COMPRESSION' which can be set to 'false' to opt
-out of compression. This is desirable when using Server Sent Events as the proxy fails to
pass Server Sent Events when compression is enabled
@facebook-github-bot
Copy link

Hi @ThomasKluiters!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make compression in webpack-dev-server configurable
2 participants