Skip to content

Minor code style and wrong expect #1463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2017
Merged

Minor code style and wrong expect #1463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/react-scripts/fixtures/kitchensink/integration/initDOM.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ const fs = require('fs')
const http = require('http')
const jsdom = require('jsdom')
const path = require('path')
const { expect } = require('chai')

let getMarkup
let resourceLoader
Expand Down Expand Up @@ -39,7 +40,7 @@ if (process.env.E2E_FILE) {
timeToWaitForJsToExecute = 100
} else {
it.only('can run jsdom (at least one of "E2E_FILE" or "E2E_URL" environment variables must be provided)', () => {
expect(new Error('This isn\'t the error you are looking for.')).toBeUndefined()
expect(new Error('This isn\'t the error you are looking for.')).to.be.undefined()
})
}

Expand Down
3 changes: 1 addition & 2 deletions packages/react-scripts/fixtures/kitchensink/src/App.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,7 @@ class App extends React.Component {
require.ensure([], () => this.setFeature(require('./features/syntax/TemplateInterpolation').default));
break;
case 'unknown-ext-inclusion':
require.ensure([], () => this.setFeature(require('./features/webpack/UnknownExtInclusion').default)
);
require.ensure([], () => this.setFeature(require('./features/webpack/UnknownExtInclusion').default));
break;
default:
this.setFeature(null);
Expand Down