Skip to content

Revert "Forbid using window properties as global variables" #2099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2017
Merged

Revert "Forbid using window properties as global variables" #2099

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
34546f4
Revert "Ignore the yarn cache directory (#2063)"
gaearon May 8, 2017
679fc6f
Revert "Forbid using window properties as global variables (#1840)"
gaearon May 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions packages/eslint-config-react-app/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,19 +26,13 @@ module.exports = {
plugins: ['import', 'flowtype', 'jsx-a11y', 'react'],

env: {
browser: true,
commonjs: true,
es6: true,
jest: true,
node: true,
},

globals: {
document: true,
window: true,
console: true,
navigator: true
},

parserOptions: {
ecmaVersion: 6,
sourceType: 'module',
Expand Down
4 changes: 2 additions & 2 deletions packages/react-scripts/fixtures/kitchensink/src/App.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ class BuiltEmitter extends Component {
}

handleReady() {
document.dispatchEvent(new window.Event('ReactFeatureDidMount'));
document.dispatchEvent(new Event('ReactFeatureDidMount'));
}

render() {
Expand Down Expand Up @@ -54,7 +54,7 @@ class App extends Component {
}

componentDidMount() {
const feature = window.location.hash.slice(1);
const feature = location.hash.slice(1);
switch (feature) {
case 'array-destructuring':
import(
Expand Down
2 changes: 1 addition & 1 deletion packages/react-scripts/fixtures/kitchensink/src/features/webpack/NoExtInclusion.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import React from 'react';
import aFileWithoutExt from './assets/aFileWithoutExt';

const text = aFileWithoutExt.includes('base64')
? window.atob(aFileWithoutExt.split('base64,')[1]).trim()
? atob(aFileWithoutExt.split('base64,')[1]).trim()
: aFileWithoutExt;

export default () => (
Expand Down
2 changes: 1 addition & 1 deletion packages/react-scripts/fixtures/kitchensink/src/features/webpack/UnknownExtInclusion.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import React from 'react';
import aFileWithExtUnknown from './assets/aFileWithExt.unknown';

const text = aFileWithExtUnknown.includes('base64')
? window.atob(aFileWithExtUnknown.split('base64,')[1]).trim()
? atob(aFileWithExtUnknown.split('base64,')[1]).trim()
: aFileWithExtUnknown;

export default () => (
Expand Down