Skip to content

Rename compressor field to compress in UglifyJsPlugin settings #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2016
Merged

Rename compressor field to compress in UglifyJsPlugin settings #264

merged 1 commit into from
Jul 28, 2016

Conversation

koistya
Copy link
Contributor

@koistya koistya commented Jul 28, 2016

@gaearon
Copy link
Contributor

gaearon commented Jul 28, 2016

Was it a no-op then? Was it renamed? Are both working?

@ghost ghost added the CLA Signed label Jul 28, 2016
@koistya
Copy link
Contributor Author

koistya commented Jul 28, 2016 •
edited
Loading

I see no compressor option in Webpack docs, maybe it was a typo in the first place?

@gaearon gaearon merged commit dd6ec95 into facebook:master Jul 28, 2016
@gaearon
Copy link
Contributor

gaearon commented Jul 28, 2016

I guess both work. Happy to change it to compress as it’s documented.

@koistya koistya deleted the uglifyjs branch July 28, 2016 19:43
@insin
Copy link
Contributor

insin commented Jul 29, 2016

I updated those docs when investigating wha actually gets passed to UglifyJS - it looked like compressor was there for backwards-compat, so I didn't mention it 😸

@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@koistya @gaearon @insin