[POC] use pkg to package react scripts to an executable #3704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viankakrisna
changed the title
|
ended up with a working build in a separate repo https://github.com/viankakrisna/react-scripts-packaged/releases/tag/0.0.1 feel free to try it! |
|
reopening for visibility :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a non-working POC for packaging react-scripts with https://github.com/zeit/pkg for (maybe) solving #3638. opening a pr here if somebody is interested to work together / continue on this. Currently, it compiles but when I do
yarn start:packagedit errors on this:maybe pkg does not play well with monorepo setup?