Skip to content

Make errors and warnings nicer #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 21, 2016
Merged

Make errors and warnings nicer #50

merged 3 commits into from
Jul 21, 2016

Conversation

gaearon
Copy link
Contributor

@gaearon gaearon commented Jul 20, 2016

There is some hackery involved but I think the result is much better.

  1. I removed all code style rules because they are frustrating when linter is in your face
  2. I changed existing lint errors to warnings so they're less obtrusive
  3. Warnings now only appear if there are no errors
  4. Some long webpack warnings are trimmed
  5. Useless stack traces are removed
  6. When there is a syntax error, duplicate parse error from linter is skipped
  7. The terminal is cleared on every file save
  8. "Bundle is VALID/INVALID" is replaced by better messages
  9. import rules are (temporarily?) disabled because of caching issue described in eslint file comments
  10. Added tips for ignoring lint warnings

Syntax error:

screen shot 2016-07-21 at 00 10 23

Lint warning:

screen shot 2016-07-21 at 00 10 40

Module not found error:

screen shot 2016-07-21 at 00 10 47

CSS parse error:

screen shot 2016-07-21 at 00 13 04

@ghost ghost added the CLA Signed label Jul 20, 2016
@ghost ghost added the CLA Signed label Jul 20, 2016
@gaearon
Copy link
Contributor Author

gaearon commented Jul 21, 2016

I’m fairly happy with this and I think it’s better than what we had before so I’m getting this in.

@gaearon gaearon merged commit 9df1c2f into master Jul 21, 2016
@gaearon gaearon deleted the nicer-output branch July 25, 2016 22:52
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant