Fixed not working websocket proxy (fix: #5280)

[mxschmitt]

Hello

this PR fixes that websockets, e.g. via Socket.io won't be proxied through the HTTP proxy.
For more information check out issue: #5280 there are also some users who tested it successfully.

Best regards

Max.

[facebook-github-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[datfinesoul]

This fix worked for me, would be great to see this get adopted.

[iansu]

Can you update the comment to explain what req.upgrade checks for?

[Timer]

We probably shouldn't proxy all upgrade requests, right?

[mxschmitt]

@Timer

We probably shouldn't proxy all upgrade requests, right?

Yes good catch, I've reworked the logic, maybe the sockjs part can be improved.

What do you think about it?

[mxschmitt]

cc @Timer any updates?

[stale]

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

[mxschmitt]

cc @iansu

[stale]

This pull request has been automatically closed because it has not had any recent activity. If you have a question or comment, please open a new issue. Thank you for your contribution!

[mxschmitt]

cc @iansu @Timer ....