Skip to content

Send proper error response upon proxy error #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 5, 2016
Merged

Send proper error response upon proxy error #588

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e54b8c1
Change http-proxy-middleware logLevel from silent to error
cloudmu Aug 26, 2016
b1b4b69
Merge remote-tracking branch 'upstream/master'
cloudmu Sep 3, 2016
4dd0d43
provide onError handler for httpProxyMiddleware
cloudmu Sep 3, 2016
1079a6e
Send proper error reponse upon proxy error.
cloudmu Sep 5, 2016
851157c
Merge with latest upstream
cloudmu Sep 5, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions scripts/start.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,15 @@ function onProxyError(proxy) {
chalk.cyan(err.code) + ').'
);
console.log();

// And immediately send the proper error response to the client.
// Otherwise, the request will eventually timeout with ERR_EMPTY_RESPONSE on the client side.
if (res.writeHead && !res.headersSent) {
res.writeHead(500);
}
res.end('Proxy error: Could not proxy request ' + req.url + ' from ' +
host + ' to ' + proxy + ' (' + err.code + ').'
);
}
}

Expand Down