-
-
Notifications
You must be signed in to change notification settings - Fork 27k
add support for Jest's moduleNameMapper configuration #6633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Allow merging of external `moduleNameMapper` configuration with the internal configuration required by react-scripts.
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
@iansu, just curious, what are the next steps to approving and merging this PR? |
Requesting an update on this PR. This is the only critical issue that is preventing my company to move from create-react-app-ts to CRA. TIA |
Looking forward to this getting merged and released! |
@nareshbhatia I'm discussing this with @iansu - we have been hard at work at 3.0, and then I think we can take a look at this for you. |
Thanks for the update, @mrmckeb. Waiting eagerly :-) |
any progress with that?? |
As far as I can tell, this change has been implemented in code. If yes, this PR can be closed. Note that the docs are still out-of-sync, moduleNameMapper is not included as a supported tag. |
Already fixed by #6055. |
Allow merging of external
moduleNameMapper
configuration with the internal configuration required by react-scripts.Fixes #4262