Skip to content

Fix for #6720: HMR not working in Firefox if proxy option present #7318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 17 commits into from
Closed

Fix for #6720: HMR not working in Firefox if proxy option present #7318

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
63d7651
All get requests for /sockjs-node* excluded from processing by http-p…
dmile Jul 3, 2019
5a72c0d
Update packages/react-dev-utils/WebpackDevServerUtils.js
dmile Jul 15, 2019
24e6526
Update minimum Node version in README (#7182)
JESii Jul 10, 2019
38470e2
Fix various typos (#7355)
minho42 Jul 15, 2019
1d54ecf
Allow title to be set when importing SVGs (#7118)
Jul 15, 2019
98aa82f
docs(svg): add tip for title props accessibility (#7374)
sudkumar Jul 15, 2019
0bc4ce5
Allow extending config used in eslint-loader (#7036)
mrmckeb Jul 16, 2019
82e49e4
jsx-no-duplicate-props ignore case fix (#7230)
rommguy Jul 16, 2019
5f026f6
Update docs to indicate dynamic imports are stage 4 (#7372)
gespispace Jul 18, 2019
34b8ee0
Fix CI issue on windows (#7385)
heyimalex Jul 18, 2019
6e8bac4
Update url-loader to 2.0.1
heyimalex Jul 16, 2019
5c9773a
Docs: remove note about TypeScript files requiring at least one expor…
MidnightDesign Jul 22, 2019
da4c49f
Add question issue template (#7423)
iansu Jul 25, 2019
376d030
Update deploy instructions in contributing guide (#7429)
iansu Jul 25, 2019
fde7eb9
Remove labels from pull request template
iansu Jul 25, 2019
6bb4629
Add explicit check for --watchAll=false (#7433)
mrmckeb Jul 26, 2019
2bd1ef4
Add ESLint 6 support (#7415)
mrmckeb Jul 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/react-dev-utils/WebpackDevServerUtils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,10 +361,13 @@ function prepareProxy(proxy, appPublicFolder) {
process.exit(1);
}

// If proxy is specified, let it handle any request except for files in the public folder.
// If proxy is specified, let it handle any request except for
// files in the public folder and WebpackDevServer socket endpoint.
function mayProxy(pathname) {
const maybePublicPath = path.resolve(appPublicFolder, pathname.slice(1));
return !fs.existsSync(maybePublicPath);
const isPublicFileRequest = fs.existsSync(maybePublicPath);
const isWdsEndpointRequest = pathname.startsWith('/sockjs-node'); // used by webpackHotDevClient
return !(isPublicFileRequest || isWdsEndpointRequest);
}

if (!/^http(s)?:\/\//.test(proxy)) {
Expand Down