Fix notations of loopback addresses #7474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wataash
requested review from
bugzpodder,
ianschmitz,
iansu,
mrmckeb and
petetnt
as code owners
wataash
force-pushed
the
loopback-address
branch
from
1b06f9a to
da01375
Compare
wataash
changed the title
wataash
force-pushed
the
loopback-address
branch
from
da01375 to
c64a061
Compare
127.0.0.1/8 refers to only a single IPv4 address "127.0.0.1" that have the subnet mask 255.255.255.0, but doesn't to 127.0.0.2. 127.0.0.0/8, which is the exact definition of the loopback addresses [1][2], includes what the regex says (127.0.0.0-127.255.255.255). [1] https://tools.ietf.org/html/rfc1122 [2] https://tools.ietf.org/html/rfc6890
wataash
force-pushed
the
loopback-address
branch
from
c64a061 to
db5809b
Compare
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
127.0.0.1/8refers to only a single IPv4 address "127.0.0.1" that have the subnet mask 255.255.255.0, but doesn't to 127.0.0.2.127.0.0.0/8, which is the exact definition of the loopback addresses [1][2], includes what the regex says (127.0.0.0-127.255.255.255).