cleanup @babel/plugin-transform-destructuring configuration #8215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryqdineen
requested review from
ianschmitz,
iansu,
mrmckeb and
petetnt
as code owners
henryqdineen
changed the title
|
I think |
|
Yep. I noticed that PR and don't see any activity on it. |
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
|
I noticed it was marked as stale. I still think this is a valid PR. |
|
If we decided to get rid of the customization, we can remove the plugin entirely as it's provided by |
|
Thanks for bringing this to our attention! I took a slightly different approach in #8353, and removed it entirely. I included you as a co-author so you get credit as well 👍 |
|
thanks @ianschmitz! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
@babel/plugin-transform-destructuringBabel plugin does not have aselectiveLooseoption currently and this code has been a source of confusion for me and possibly others. It was introduced in #5997 and I'm not sure if the intention was to wait for theselectiveLooseoption to be available. Even if this worked as hoped for I think that onlyuseStateanduseReducershould be targeted for this optimization.Thanks! Please let me know if I'm missing something obvious.