Skip to content

Ignores my-app* directories #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2016

Conversation

npverni
Copy link
Contributor

@npverni npverni commented Jul 22, 2016

The Contributing instructions in the README give my-app as the sample
app name when running npm run create-react-app my-app. This just adds
those directories to the .gitignore so they don't accidentally get
committed.

The Contributing instructions in the README give my-app as the sample
app name when running `npm run create-react-app my-app`. This just adds
those directories to the .gitignore so they don't accidentally get
committed.
@ghost
Copy link

ghost commented Jul 22, 2016

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

@ghost
Copy link

ghost commented Jul 22, 2016

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@ghost ghost added the CLA Signed label Jul 22, 2016
@gaearon
Copy link
Contributor

gaearon commented Jul 22, 2016

I’m 👍 with this, it’s frustrating to delete those temporary directories.

@gaearon gaearon merged commit 1bffa4c into facebook:master Jul 22, 2016
@vjeux
Copy link
Contributor

vjeux commented Jul 22, 2016

Thanks!

@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants