Skip to content

package.json defines main entry to template.json #8894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

emoriarty
Copy link

Added description to make sure that new template packages includes in their packages.json the main prop pointing to template.json.

Added description to make sure that new template packages includes in their `packages.json` the main prop pointing to `template.json`.
@emoriarty emoriarty requested review from amyrlam and iansu as code owners April 25, 2020 12:31
@facebook-github-bot
Copy link

Hi @emoriarty!

Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@ianschmitz ianschmitz added this to the 4.0 milestone Apr 29, 2020
@iansu iansu requested a review from mrmckeb May 5, 2020 03:28
@mrmckeb
Copy link
Contributor

mrmckeb commented May 5, 2020

Hi @emoriarty, thanks for the PR. This has been resolved and as of the next release, will no longer be needed.

#8734

At this stage I think the change to the docs is too late...

@mrmckeb mrmckeb closed this May 5, 2020
@lock lock bot locked and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants