Skip to content

#9739 Set proxy setting from environment variables, falling back to p… #9740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

wozzo
Copy link

@wozzo wozzo commented Oct 2, 2020

Implements #9739 allowing the proxy target to be set using environment variables and falling back to package.json if none exists.

Tested by running a project with the change applied.

  1. Ran with no proxy environment variable, but with proxy in package.json. Result: Used proxy from package.json
  2. Ran with proxy environment variable and package.json. Result: Used proxy from environment variable
  3. Ran with proxy environment variable and none in package.json. Result: Used proxy from environment variable

@facebook-github-bot
Copy link

Hi @wozzo!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@wozzo
Copy link
Author

wozzo commented Oct 2, 2020

CLA completed

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

1 similar comment
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@stale
Copy link

stale bot commented Jan 9, 2022

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Jan 9, 2022
@wozzo
Copy link
Author

wozzo commented Jan 9, 2022

Still needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants