MySQL persistent connection never working if mysqli.max_persistent=-1 (default value)

[nilwave]

From hphp/runtime/ext/mysql/mysql_common.cpp:

if (MySQL::IsAllowPersistent() &&
628 MySQL::GetCurrentNumPersistent() < MySQL::GetMaxNumPersistent() &&
629 persistent) {
630 auto p_mySQL = MySQL::GetPersistent(host, port, socket, username,
631 password, client_flags);

MySQL::GetMaxNumPersistent() = -1 (default value) -> if never passing, I suggest

if (persistent && (MySQL::IsAllowPersistent() && (MySQL::GetMaxNumPersistent() == -1 || (MySQL::GetCurrentNumPersistent() < MySQL::GetMaxNumPersistent() ))))

[nilwave]

Also please note that if mysqli.reconnect = 0 (default value) mysql persistent connections will not work.

To make persistent connections work properly:

mysqli.reconnect = 1
mysqli.max_persistent = 999 (??)

[aorenste]

Probably related to #6542

[nilwave]

It's not related to #6542

[aorenste]

@nilwave - You're right. I misread what you were saying when I quickly looked at this issue (and since about 4 other issues were related to 6542). This seems to be that we're not treating (max_persistent == -1) as infinite.

[lexidor]

I am going over old issues on this repository, to see which ones apply to the current versions of hhvm.

This issue is is about etc/mysqli, which has been removed from hhvm in version 4.9.0.