This repository was archived by the owner on Jun 26, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ouse. (Even if you mouse outside of the selector.)
This doesn't resolve all of the requests in #1099, but I think it hits most of the low hanging fruit ones. I'll follow up on some of the others later. If you don't have the time/energy to review this PR, I feel comfortable enough about it to just merge as-is. Just wanted to offer before plowing forward. 😄 |
gaearon
approved these changes
Aug 19, 2018
OrDuan
pushed a commit
to OrDuan/react-devtools
that referenced
this pull request
Aug 23, 2018
* Click in empty space of flamegraph/ranked chart to deselect an element * Added close/stop-inspecting button to fiber detail pane * Show unrounded durations on hover for chart tooltips * Make selected commit more prominent in snapshot selector * Left/right arrow keys navigate selected snapshot/commit * Snapshot selector auto-scrolls to ensure selected commit is visible * Snapshot selector shows filtered commit list when inspecting fiber durations * Tweaked selected snapshot style again to stand out more * Single click on arrow toggles tree open/closed * Moved 'show native elements?' option into new Profiler settings panel * "Commit time" -> "Committed at" * Left pad number to avoid reflow when stepping through snapshots * When dragging, don't leave the dragging state until you release the mouse. (Even if you mouse outside of the selector.) * Add control to filter commits below a thresold (ms) * Commit filtering applies to snapshot durations view as well
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1099
Demo build available at react-devtools-profiler-prerelease.now.sh
Flamegraph
Horizontal snapshot selector
Right hand details pane
Component durations bar chart
Elements tree view
General