Skip to content

Docs: Remove deprecated method didReceiveLocalNotification from Push Notification iOS #2215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Docs: Remove deprecated method didReceiveLocalNotification from Push Notification iOS #2215

wants to merge 1 commit into from

Conversation

carloscuesta
Copy link

Description

This is related with the following issue: facebook/react-native#26199

According to iOS docs, didReceiveLocalNotification is deprecated and should be replaced by

Screenshot 2020-09-17 at 17 09 57

This PR removes the following method from the PushNotificationIOS documentation

@react-native-bot
Copy link

Deploy preview for react-native ready!

Built with commit 78a7c27

https://deploy-preview-2215--react-native.netlify.app

Changes to docs/ are reflected in the next "master" version.

Thank you for your contributions.

How to ContributeDocumentation Sources

Copy link
Collaborator

@Simek Simek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @carloscuesta, unfortunately the method didReceiveLocalNotification is still part of the React Native source code, so it should remain documented.

If it's an important change for you, you can try to remove the didReceiveLocalNotification from the core and then repost this PR.

Also PushNotificationIOS has been deprecated a while ago and the recommended package should be used instead.

@Simek Simek closed this Sep 18, 2020
@carloscuesta
Copy link
Author

No problem @Simek thanks for taking the time on reviewing the PR! Even though PushNotificationIOS is deprecated I considered that it was a valuable thing to update, that's why I opened it! 😊

@carloscuesta carloscuesta deleted the fix-push-notifications-ios-docs branch September 18, 2020 09:48
@Simek
Copy link
Collaborator

Simek commented Sep 18, 2020

@carloscuesta Thank you for the effort! This change is still welcome, but you need to update the React Native code first. 🙂

But this might be a bit problematic, since the whole library is scheduled for the removal from the core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants