Skip to content

Commit 5f841a9

Browse files
committed
[Setup] Remove AdSupport from the list of libraries linked by default
Summary: Many apps don't need AdSupport, especially not when people are making a sample app to learn React. Apps that do want it can link it in like any other library. Fixes #1303, see the discussion there. Closes #1305 Github Author: James Ide <[email protected]> Test Plan: Imported from GitHub, without a `Test Plan:` line.
1 parent 64c0bb0 commit 5f841a9

File tree

1 file changed

+0
-30
lines changed

1 file changed

+0
-30
lines changed

Examples/SampleApp/SampleApp.xcodeproj/project.pbxproj

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
/* Begin PBXBuildFile section */
1010
008F07F31AC5B25A0029DE68 /* main.jsbundle in Resources */ = {isa = PBXBuildFile; fileRef = 008F07F21AC5B25A0029DE68 /* main.jsbundle */; };
1111
00C302E51ABCBA2D00DB3ED1 /* libRCTActionSheet.a in Frameworks */ = {isa = PBXBuildFile; fileRef = 00C302AC1ABCB8CE00DB3ED1 /* libRCTActionSheet.a */; };
12-
00C302E61ABCBA2D00DB3ED1 /* libRCTAdSupport.a in Frameworks */ = {isa = PBXBuildFile; fileRef = 00C302B41ABCB8E700DB3ED1 /* libRCTAdSupport.a */; };
1312
00C302E71ABCBA2D00DB3ED1 /* libRCTGeolocation.a in Frameworks */ = {isa = PBXBuildFile; fileRef = 00C302BA1ABCB90400DB3ED1 /* libRCTGeolocation.a */; };
1413
00C302E81ABCBA2D00DB3ED1 /* libRCTImage.a in Frameworks */ = {isa = PBXBuildFile; fileRef = 00C302C01ABCB91800DB3ED1 /* libRCTImage.a */; };
1514
00C302E91ABCBA2D00DB3ED1 /* libRCTNetwork.a in Frameworks */ = {isa = PBXBuildFile; fileRef = 00C302DC1ABCB9D200DB3ED1 /* libRCTNetwork.a */; };
@@ -34,13 +33,6 @@
3433
remoteGlobalIDString = 134814201AA4EA6300B7C361;
3534
remoteInfo = RCTActionSheet;
3635
};
37-
00C302B31ABCB8E700DB3ED1 /* PBXContainerItemProxy */ = {
38-
isa = PBXContainerItemProxy;
39-
containerPortal = 00C302AF1ABCB8E700DB3ED1 /* RCTAdSupport.xcodeproj */;
40-
proxyType = 2;
41-
remoteGlobalIDString = 832C81801AAF6DEF007FA2F7;
42-
remoteInfo = RCTAdSupport;
43-
};
4436
00C302B91ABCB90400DB3ED1 /* PBXContainerItemProxy */ = {
4537
isa = PBXContainerItemProxy;
4638
containerPortal = 00C302B51ABCB90400DB3ED1 /* RCTGeolocation.xcodeproj */;
@@ -116,7 +108,6 @@
116108
/* Begin PBXFileReference section */
117109
008F07F21AC5B25A0029DE68 /* main.jsbundle */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; name = main.jsbundle; path = iOS/main.jsbundle; sourceTree = "<group>"; };
118110
00C302A71ABCB8CE00DB3ED1 /* RCTActionSheet.xcodeproj */ = {isa = PBXFileReference; lastKnownFileType = "wrapper.pb-project"; name = RCTActionSheet.xcodeproj; path = ../../Libraries/ActionSheetIOS/RCTActionSheet.xcodeproj; sourceTree = "<group>"; };
119-
00C302AF1ABCB8E700DB3ED1 /* RCTAdSupport.xcodeproj */ = {isa = PBXFileReference; lastKnownFileType = "wrapper.pb-project"; name = RCTAdSupport.xcodeproj; path = ../../Libraries/AdSupport/RCTAdSupport.xcodeproj; sourceTree = "<group>"; };
120111
00C302B51ABCB90400DB3ED1 /* RCTGeolocation.xcodeproj */ = {isa = PBXFileReference; lastKnownFileType = "wrapper.pb-project"; name = RCTGeolocation.xcodeproj; path = ../../Libraries/Geolocation/RCTGeolocation.xcodeproj; sourceTree = "<group>"; };
121112
00C302BB1ABCB91800DB3ED1 /* RCTImage.xcodeproj */ = {isa = PBXFileReference; lastKnownFileType = "wrapper.pb-project"; name = RCTImage.xcodeproj; path = ../../Libraries/Image/RCTImage.xcodeproj; sourceTree = "<group>"; };
122113
00C302D31ABCB9D200DB3ED1 /* RCTNetwork.xcodeproj */ = {isa = PBXFileReference; lastKnownFileType = "wrapper.pb-project"; name = RCTNetwork.xcodeproj; path = ../../Libraries/Network/RCTNetwork.xcodeproj; sourceTree = "<group>"; };
@@ -152,7 +143,6 @@
152143
files = (
153144
146834051AC3E58100842450 /* libReact.a in Frameworks */,
154145
00C302E51ABCBA2D00DB3ED1 /* libRCTActionSheet.a in Frameworks */,
155-
00C302E61ABCBA2D00DB3ED1 /* libRCTAdSupport.a in Frameworks */,
156146
00C302E71ABCBA2D00DB3ED1 /* libRCTGeolocation.a in Frameworks */,
157147
00C302E81ABCBA2D00DB3ED1 /* libRCTImage.a in Frameworks */,
158148
133E29F31AD74F7200F7D852 /* libRCTLinking.a in Frameworks */,
@@ -175,14 +165,6 @@
175165
name = Products;
176166
sourceTree = "<group>";
177167
};
178-
00C302B01ABCB8E700DB3ED1 /* Products */ = {
179-
isa = PBXGroup;
180-
children = (
181-
00C302B41ABCB8E700DB3ED1 /* libRCTAdSupport.a */,
182-
);
183-
name = Products;
184-
sourceTree = "<group>";
185-
};
186168
00C302B61ABCB90400DB3ED1 /* Products */ = {
187169
isa = PBXGroup;
188170
children = (
@@ -283,7 +265,6 @@
283265
children = (
284266
146833FF1AC3E56700842450 /* React.xcodeproj */,
285267
00C302A71ABCB8CE00DB3ED1 /* RCTActionSheet.xcodeproj */,
286-
00C302AF1ABCB8E700DB3ED1 /* RCTAdSupport.xcodeproj */,
287268
00C302B51ABCB90400DB3ED1 /* RCTGeolocation.xcodeproj */,
288269
00C302BB1ABCB91800DB3ED1 /* RCTImage.xcodeproj */,
289270
78C398B01ACF4ADC00677621 /* RCTLinking.xcodeproj */,
@@ -394,10 +375,6 @@
394375
ProductGroup = 00C302A81ABCB8CE00DB3ED1 /* Products */;
395376
ProjectRef = 00C302A71ABCB8CE00DB3ED1 /* RCTActionSheet.xcodeproj */;
396377
},
397-
{
398-
ProductGroup = 00C302B01ABCB8E700DB3ED1 /* Products */;
399-
ProjectRef = 00C302AF1ABCB8E700DB3ED1 /* RCTAdSupport.xcodeproj */;
400-
},
401378
{
402379
ProductGroup = 00C302B61ABCB90400DB3ED1 /* Products */;
403380
ProjectRef = 00C302B51ABCB90400DB3ED1 /* RCTGeolocation.xcodeproj */;
@@ -451,13 +428,6 @@
451428
remoteRef = 00C302AB1ABCB8CE00DB3ED1 /* PBXContainerItemProxy */;
452429
sourceTree = BUILT_PRODUCTS_DIR;
453430
};
454-
00C302B41ABCB8E700DB3ED1 /* libRCTAdSupport.a */ = {
455-
isa = PBXReferenceProxy;
456-
fileType = archive.ar;
457-
path = libRCTAdSupport.a;
458-
remoteRef = 00C302B31ABCB8E700DB3ED1 /* PBXContainerItemProxy */;
459-
sourceTree = BUILT_PRODUCTS_DIR;
460-
};
461431
00C302BA1ABCB90400DB3ED1 /* libRCTGeolocation.a */ = {
462432
isa = PBXReferenceProxy;
463433
fileType = archive.ar;

0 commit comments

Comments
 (0)