[Setup] Remove AdSupport from the list of libraries linked by default

[ide]

Many apps don't need AdSupport, especially not when people are making a sample app to learn React. Apps that do want it can link it in like any other library.

Fixes #1303, see the discussion there.

[vjeux]

@facebook-github-bot import

[vjeux]

This is a good workaround, we need to find an easy way to link those back and to mention in the docs that they are not being linked by default

[facebook-github-bot]

Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/832610953454845/int_phab to review.

[sahrens]

Thanks James!

I don't think this qualifies as a "workaround" - I think it's straight up the right thing. It will be a total non-issue once we get nice REM/react-native link/some other native dep magic fully up and running.

[vjeux]

This is a workaround until we have a good way to link it back :) Then, it's going to be the right thing to do :p

[sahrens]

We should leave this out of the sample app permanently. Long term you should be able to just add the JS require, run react-native install or maybe npm install and it will auto-link the workspace and lib.

On May 15, 2015, at 4:42 PM, Christopher Chedeau [email protected] wrote:

This is a workaround until we have a good way to link it back :) Then, it's going to be the right thing to do :p

—
Reply to this email directly or view it on GitHub.

[sahrens]

Maybe add it to your package.json

On May 15, 2015, at 4:42 PM, Christopher Chedeau [email protected] wrote:

This is a workaround until we have a good way to link it back :) Then, it's going to be the right thing to do :p

—
Reply to this email directly or view it on GitHub.