-
Notifications
You must be signed in to change notification settings - Fork 24.8k
Closed
Labels
Resolution: LockedThis issue was locked by the bot.This issue was locked by the bot.
Description
Description
The product-name regex in local-cli/runIOS/runIOS.js
line 160 fails to match the product name. This is probably because there is a $
to match the end of the string, but there is no guarantee that the product name string (which is in format of export FULL_PRODUCT_NAME=Test.app
) is at the end of the buildOutput
string.
Referencing pull-request: #13001, as it seems relevant to this issue.
Reproduction Steps and Sample Code
Please refer to the below screenshot. Below shows that the regex matches when the product name string is at the end of the line.
The next screenshot does not have any match because the product name string is not at the end of the line.
Solution
Fix the regex so that it doesn't assume that the product-name string is at the end of the buildOutput
string.
Additional Information
- React Native version: 0.44.0
- Platform: iOS
- Development Operating System: MacOS
- Dev tools: iOS simulator
prithsharma
Metadata
Metadata
Assignees
Labels
Resolution: LockedThis issue was locked by the bot.This issue was locked by the bot.
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
chris-yoon90 commentedon May 4, 2017
Regex is missing multi-line flag so that's probably why it's not matching.
dkpalmer commentedon May 7, 2017
multi-line is indeed the issue. I put a PR up at #13826.
hramos commentedon Jul 20, 2017
Hi there! This issue is being closed because it has been inactive for a while. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we're automatically closing issues after a period of inactivity. Please do not take it personally!
If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:
If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution.