Skip to content

[Sample project] shouldn't gitignore project.xcworkspace #1560

@itsananderson

Description

@itsananderson

See discussion in #463 where @ide explained why just xcuserdata should be ignored, rather than all of project.xcworkspace.

In this commit: 9b513ed, project.xcworkspace was added to the .gitignore, as well as the sample project's _gitignore file.

One place where this is causing issues is Visual Studio Online, which requires an xcworkspace file to configure automated builds. If I understand correctly, the CocoaSpec project also recommends opening the project.xcworkspace instead of the xcodeproj, so it seems like that would also cause issues.

The workaround here is pretty easy... just remove the project.xcworkspace line from the .gitignore after running react-native init, but would it be a better default to not ignore project.xcworkspace?

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions