0.52.0-rc.0: Yoga Value Conversion Issue preventing build

[jaysig]

Is this a bug report?

Yes

Have you read the Contributing Guidelines?

Yes

Environment

Steps to Reproduce

(Write your steps here:)

1. Try to build app in xCode
2. Receive Error Implicit conversion loses integer precision: 'size_type' (aka 'unsigned long') to 'const uint32_t' (aka 'const unsigned int')
   line 208 in YGNodePrint.cpp const uint32_t childCount = node->children.size();

Not sure if this is related but Line 201 and 293 of Yoga.cpp are also throwing logic errors of Null pointer argument in call to memory copy function

Expected Behavior

I expected my app to work. It had hung up at the splash screen with no errors except the yoga logic errors and I assumed the newer version would resolve them.

Actual Behavior

The app is unable to build due to the yoga issue and xCodes says there are two other logic errors in Yoga.

Reproducible Demo

I would imagine this would just show up in any new project; however, any suggested steps to resolve it would be appreciated.

[shameemz]

Facing the same issue after upgrading to 0.52.0-rc.0.

[jcady]

I'm seeing this same issue in Xcode 9.2 with 0.52.0-rc.0.

[hpb0412]

The same thing happened for me on Xcode 9.2 (9C40b) with yoga 0.52.0-rc.0 (after update to react-native@0.52.0-rc.0)

[blackxored]

It is not fixed on master either.

[gabrielbull]

Version 0.52.0 was released with this bug still present. I bet there's going to be an influx of people having this issue now. We really should have resolved this issue before releasing 0.52.0 😬.

[gabrielbull]

Let's bring in @priteshrnandgaonkar into this discussion as he's the one who worked on the file causing issues.

[turnrye]

b08a912 would be the commit I believe

[priteshrnandgaonkar]

I ran RNTester shipped with RC. It built and ran successfully. The messages which are mentioned above are just warnings, those shouldn't be the cause of the problem. Although I will fix those warnings

[fungilation]

@gabrielbull I confirm Xcode build stalled at this exact same line with same error, in YGNodePrint.cpp, on RN 0.52.0. How/Why did RN release ship with a glaring show stopper again like this is a good question. 😭

Any idea for a workaround?

[LeVadim]

Same issue here, it won't build due to this error

[kontinuity]

❌  ...node_modules/react-native/ReactCommon/yoga/yoga/YGNodePrint.cpp:208:46: implicit conversion loses integer precision: 'size_type' (aka 'unsigned long') to 'const uint32_t' (aka 'const unsigned int') [-Werror,-Wshorten-64-to-32]

  const uint32_t childCount = node->children.size();
              ^~~~~~


▸ Compiling yoga-dummy.m
▸ Compiling Yoga.cpp
** ARCHIVE FAILED **


The following build commands failed:
	CompileC ...Library/Developer/Xcode/DerivedData/xxxx-eouawjjkefabkkexnsxilamhdmzd/Build/Intermediates.noindex/ArchiveIntermediates/xxxx-Release/IntermediateBuildFilesPath/Pods.build/Release-iphoneos/yoga.build/Objects-normal/arm64/YGNodePrint.o ...node_modules/react-native/ReactCommon/yoga/yoga/YGNodePrint.cpp normal arm64 c++ com.apple.compilers.llvm.clang.1_0.compiler

The build fails due to this fatal error.

[hanweixing]

Got this too. Mark this issue, expect solutions soon.

[bkitduy]

Fix please :(. I'm facing this issue (React 0.52.0 - yoga 0.52.0)

[hitbear518]

Same issue. Integrated with existing app, upgraded from 0.50.4

[raviatflexiloans]

Facing the same issues. Getting following error:

error: implicit conversionloses integer precision: 'size_type' (aka 'unsigned long') to 'uint32_t' (aka 'unsigned int') [-Werror,-Wshorten-64-to-32]
return node->children.size();